Add checks #92
Merged
Add checks #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
commented
Dec 7, 2020
silvanocerza
reviewed
Dec 7, 2020
silvanocerza
reviewed
Dec 7, 2020
silvanocerza
reviewed
Dec 7, 2020
silvanocerza
suggested changes
Dec 7, 2020
per1234
force-pushed
the
per1234/add-checks
branch
from
56172b6 to
171133b
Compare
Previously, tests that needed a library without examples used a library that just happened to not have examples for test data. Using test data specifically intended to provide the necessary conditions will result in less fragile tests.
If a file with one of the names supported by the licensee gem is in the root of the repository containing the text of a standard license, GitHub recognizes the license type and enables some nice integrations. So having such a file is best practices. These checks are only for the presence of the file, rather than their contents.
This checks whether sketch.json is compliant with the expected data format.
per1234
force-pushed
the
per1234/add-checks
branch
from
171133b to
0ebcb78
Compare
silvanocerza
approved these changes
Dec 10, 2020
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.