Skip to content

Conversation

@kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Oct 5, 2022

Motivation

This PR depends on #1530.


This PR ensures that the Arduino_BuiltIn will be installed on the first start in case of absence.

Change description

Other information

To verify:

Closes #1526


Local verification after wiping the localStorage content and starting IDE2.

Platform arduino:[email protected] already installed
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Platform arduino:[email protected] already installed
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Platform arduino:[email protected] already installed
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 5, 2022
@kittaakos kittaakos requested review from AlbyIanna and per1234 October 5, 2022 14:05
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

on the first IDE2 startup.

Closes #1526

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos merged commit 2d2be1f into main Oct 7, 2022
@kittaakos kittaakos deleted the #1526 branch October 7, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect libraries installed by first run installation

3 participants