Skip to content

Remove tests that cannot be run #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2024
Merged

Remove tests that cannot be run #909

merged 1 commit into from
Mar 4, 2024

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Feb 28, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • [] Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Test removal

  • What is the new behavior?

Tests that cannot be run are being removed.

  • Does this PR introduce a breaking change?

No

  • Other information:

@MatteoPologruto MatteoPologruto added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 28, 2024
@MatteoPologruto MatteoPologruto self-assigned this Feb 28, 2024
umbynos
umbynos suggested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually these test are not run... We should remove them

@MatteoPologruto MatteoPologruto changed the title Use download servers to obtain the latest agent version Remove tests that cannot be run Feb 28, 2024
@MatteoPologruto MatteoPologruto merged commit 325f7a4 into arduino:main Mar 4, 2024
@MatteoPologruto MatteoPologruto deleted the update-version-url branch March 4, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xayton Xayton Xayton approved these changes

+1 more reviewer

@umbynos umbynos umbynos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MatteoPologruto MatteoPologruto

Labels

topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MatteoPologruto @Xayton @umbynos