Upload the signed bundle to s3 #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
added
type: enhancement
|
Notice that I opened this against |
Codecov ReportBase: 10.94% // Head: 10.94% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## fix-(s)ventura-code #756 +/- ##
====================================================
Coverage 10.94% 10.94%
====================================================
Files 50 50
Lines 3892 3892
====================================================
Hits 426 426
Misses 3412 3412
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
The CI is failing because I stopped it (in order to skip the release creation). The bundle is generated in http://downloads.arduino.cc/CreateAgent/Stable/1.2.8/ArduinoCreateAgent.app_notarized.zip |
shouldn't be triggered on |
cmaglie
approved these changes
Jan 27, 2023
cmaglie
changed the title
cmaglie
pushed a commit
that referenced
this pull request
Jan 27, 2023
* remove some code duplication regarding prerelease calculation * add upload of the notarized bundle to s3 download bucket * add upload of the notarized bundle to s3 download bucket
1 task
cmaglie
pushed a commit
that referenced
this pull request
Feb 10, 2023
* remove some code duplication regarding prerelease calculation * add upload of the notarized bundle to s3 download bucket * add upload of the notarized bundle to s3 download bucket
cmaglie
pushed a commit
that referenced
this pull request
Feb 13, 2023
* remove some code duplication regarding prerelease calculation * add upload of the notarized bundle to s3 download bucket * add upload of the notarized bundle to s3 download bucket
cmaglie
pushed a commit
that referenced
this pull request
Feb 14, 2023
* remove some code duplication regarding prerelease calculation * add upload of the notarized bundle to s3 download bucket * add upload of the notarized bundle to s3 download bucket
cmaglie
added a commit
that referenced
this pull request
Feb 15, 2023
* Upload the signed bundle to s3 (#756) * remove some code duplication regarding prerelease calculation * add upload of the notarized bundle to s3 download bucket * add upload of the notarized bundle to s3 download bucket * add json to enable autoupdate with the new agent logic (#759) * add json to enable autoupdate with the new agent logic * binary output of the archive https://unix.stackexchange.com/questions/3675/how-can-i-get-a-base64-encoded-shax-on-the-cli * workaround to allow darwin-arm64 to autoupdate * parallelize bundle creation and notarization. This will be helpful if/when we decide to build for darwin-arm64. For now this is useful because we do not offer a binary for m1 yet, `runtime.GOARCH` on an m1 machine returns ARM64, so the call for the update file would fail * Implemented the autoupdater for MacOS * Added more logging and fixed upgrade procedure * Use MacOS openApplicationAtURL syscall to re-run updated app * Bump minimum required macosx version to 10.15 This is required because the auto-update uses the function warning: 'openApplicationAtURL:configuration:completionHandler:' is only available on macOS 10.15 or newer [-Wunguarded-availability-new] * Removed diff-based updates * Fixed update URL for different update methods * fix invalid workflow * Always complete the old auto-upgrade procedure This is required for clients upgrading from versions <=1.2.7 * Moved the syscall to openApplicationAtURL inside Systray * Added fallback restart for macosx. * added some more logging --------- Co-authored-by: Umberto Baldi <[email protected]> Co-authored-by: Umberto Baldi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
CI enhancement
The autoupdate bundle is not pushed to s3 download servers
During a release, a notarized zipped bundle is produced and pushed directly to s3 download server, inside a directory that includes the version tag.
no
Close #736