Skip to content

serial-discovery now talks pluggable discovery protocol v1 #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2021
Merged

serial-discovery now talks pluggable discovery protocol v1 #1327

merged 2 commits into from
Jun 18, 2021

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 18, 2021

  • Updated serial-discovery
  • discovery.Discovery class now talks pluggable discovery protocol v1
  • Also added a grpc Port for future use

This change should not break anything.

silvanocerza
silvanocerza reviewed Jun 18, 2021
View reviewed changes
silvanocerza
silvanocerza reviewed Jun 18, 2021
View reviewed changes
silvanocerza
silvanocerza suggested changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all it's fine for me, but I think debug printing could be done in a better way.

@cmaglie cmaglie force-pushed the pluggable-discovery-3 branch from 75e09d8 to 6120543 Compare June 18, 2021 09:32
@cmaglie cmaglie merged commit b4b4ad6 into arduino:master Jun 18, 2021
@cmaglie cmaglie deleted the pluggable-discovery-3 branch June 18, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@silvanocerza silvanocerza silvanocerza approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @silvanocerza