Ethernet library: add missing functions #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pennam merged 38 commits into arduino:main from leonardocavagnis:eth_lib_fix_main

Oct 14, 2025

Member

leonardocavagnis commented Aug 28, 2025

Rebase PR #160 on main branch

leonardocavagnis requested a review from pennam

August 28, 2025 15:07

leonardocavagnis mentioned this pull request

[deprecated] Ethernet library: add missing functions #160

Closed

leonardocavagnis force-pushed the eth_lib_fix_main branch 2 times, most recently from 3ff6a2a to e0d539b Compare

August 28, 2025 16:13

pennam reviewed

View reviewed changes

libraries/Ethernet/library.properties Outdated Show resolved Hide resolved

leonardocavagnis force-pushed the eth_lib_fix_main branch from e0d539b to b6c2f6d Compare

August 29, 2025 10:20

pennam reviewed

View reviewed changes

libraries/Ethernet/examples/WebClientRepeatingManual/WebClientRepeatingManual.ino Outdated Show resolved Hide resolved

pennam reviewed

View reviewed changes

libraries/Ethernet/examples/WebClientRepeating/WebClientRepeating.ino Outdated Show resolved Hide resolved

pennam reviewed

View reviewed changes

libraries/Ethernet/examples/WebClientRepeating/WebClientRepeating.ino Outdated Show resolved Hide resolved

pennam reviewed

View reviewed changes

libraries/Ethernet/examples/WebClientRepeating/WebClientRepeating.ino Outdated Show resolved Hide resolved

leonardocavagnis force-pushed the eth_lib_fix_main branch from 0e91c7c to 0646d5a Compare

September 5, 2025 14:50

Member Author

leonardocavagnis commented Sep 5, 2025

All check passed and review done @pennam

facchinm approved these changes

View reviewed changes

leonardocavagnis added 17 commits

October 10, 2025 10:36


          ethernet lib: set mac address, log module fix

d7cb41b


          Ethernet lib: move Ethernet functions implementation in .cpp

76402c0


          Ethernet lib: tentative set manual IP,subnet,gateway

b6f0564


          Ethernet lib: add set IP, Subnet, Gateway functions

b33e1e2


          Ethernet lib: add disconnect fun

c780380


          Ethernet lib: extract Ethernet lib from SocketWrapper lib

f6a58f2


          Ethernet lib: add default examples

b9941ee


          ethernet lib: fix examples

08d3bcc


          eth lib: disable log print in SocketWrapper module

d976791


          eth lib: add new line at end of file


          ethernet lib: add only zephyr architecture in library properties

100ac13


          ethernet lib: remove no-standard example

648b1b7


          ethernet lib: remove wiznet stuff

d589d60


          socket wrapper: cosmetics clang

8678d18


          ethernet lib: cosmetics clang

c5420cf


          ethernet lib: restore default WebClientRepeating.ino example

f59cbae


          ethernet lib: restore default WebServer.ino example

3be4ea0

leonardocavagnis and others added 4 commits

October 10, 2025 10:36


          ethernet lib: move examples to arduino.tips

2bdc914


          ethernet: fix ethernet in variant MCXN947

1eff286


          ethernet: fix architecture in library properties

621ab56


          ethernet: fix interface discovery on c33

aae3937

pennam force-pushed the eth_lib_fix_main branch from 0646d5a to aae3937 Compare

October 10, 2025 10:05

pennam commented Oct 10, 2025

rebased on master
fixed architecture in library property
(re)fixed interface discovery for portenta c33

pennam added 2 commits

October 10, 2025 14:52


          ethernet: fix MACAddress(uint8_t *mac)

c9cfdeb


          ethernet: fix setMACAddress

7a10967

pennam force-pushed the eth_lib_fix_main branch 2 times, most recently from 6f04ac2 to fce7669 Compare

October 13, 2025 13:25

pennam commented Oct 13, 2025

@leonardocavagnis can you doublecheck the example AdvancedChatServer ? I'm testing it but something is broken.

pennam added 13 commits

October 14, 2025 10:03


          ethernet: remove setter overloads

b15ccf2


          ethernet: remove disconnect overload

8782a24


          ethernet: remove getters overloads

b635f92


          networkInterface: rename setLocalIPFull to config

cd9baae


          ethernet: refactor begin()

35998e9


          ethernet: remove init()

  should be commented by default in the examples


          ethernet: add maintain() dummy implementation

98aba73


          ethernet: add dummy implementation of setRetransmissionTimeout

21553b3


          ethernet: add dummy implementation of setRetransmissionCount

17485b7


          ethernet: uniform example Waiting for link on

2c8f287


          ethernet: format examples

0ad6fc0


          NetworkInterface: make dtor virtual

464ab15


          ethernet: UdpNtpClient, avoid double checking link status

51848ac

pennam force-pushed the eth_lib_fix_main branch from a5a093c to 51848ac Compare

October 14, 2025 08:03

pennam added 2 commits

October 14, 2025 15:18


          ethernet: remove examples that need more testing

076840f


          ethernet: fix TelnetClient wait for serial

7b6f193

pennam commented Oct 14, 2025

Examples tested on Portenta H7 and Portenta C33

pennam merged commit 058595d into arduino:main

18 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet