Skip to content

Update comments to reflect Stream functions changed from private to protected #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Update comments to reflect Stream functions changed from private to protected #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cores/arduino/Stream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

#define PARSE_TIMEOUT 1000 // default number of milli-seconds to wait

// private method to read stream with timeout
// protected method to read stream with timeout
int Stream::timedRead()
{
int c;
Expand All @@ -39,7 +39,7 @@ int Stream::timedRead()
return -1; // -1 indicates timeout
}

// private method to peek stream with timeout
// protected method to peek stream with timeout
int Stream::timedPeek()
{
int c;
Expand Down
4 changes: 2 additions & 2 deletions cores/arduino/Stream.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ class Stream : public Print
protected:
unsigned long _timeout; // number of milliseconds to wait for the next char before aborting timed read
unsigned long _startMillis; // used for timeout measurement
int timedRead(); // private method to read stream with timeout
int timedPeek(); // private method to peek stream with timeout
int timedRead(); // read stream with timeout
int timedPeek(); // peek stream with timeout
int peekNextDigit(LookaheadMode lookahead, bool detectDecimal); // returns the next numeric digit in the stream or -1 if timeout

public:
Expand Down