ESPHost - fix softAP password check #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: imperfection
pennam
requested changes
Feb 15, 2024
There was a problem hiding this comment.
@JAndrassy i think it should be like this
if ((cfg.encryption_mode != WIFI_AUTH_OPEN) &&
((strlen((char *)&cfg.pwd) > MAX_PWD_LENGTH) ||
(strlen((char *)&cfg.pwd) < MIN_PWD_LENGTH))) {
|
yes. I just did a quick fix because I got error about password for WIFI_AUTH_OPEN and at the same time I released that just before that I used a short password and it took me a while to figure out why the PC doesn't want to connect. |
JAndrassy
force-pushed
the
esphost_fix_pwd_check
branch
from
c373408 to
d27eff5
Compare
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SoftAP password length was checked for open network and was not checked for secured