This repository was archived by the owner on Apr 16, 2021. It is now read-only.
Improve PDM microphone reliability #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clock usually gets activated only by RADIO (BLE). Helps keeping the microphone jitter low.
There was a problem hiding this comment.
@facchinm the changes seem fine, tested the following:
- PDMSerialPlotter example
- TensorFlow Lite Micro - microspeech example. "yes" detection seems good. "no" didn't work but this is the same outcome for me as before.
libraries/PDM/src/PDM.cpp
Outdated
| @@ -48,10 +48,15 @@ int PDMClass::begin(int channels, long sampleRate) | |||
| { | |||
| _channels = channels; | |||
|
|
|||
| NRF_CLOCK->EVENTS_HFCLKSTARTED = 0; | |||
| NRF_CLOCK->TASKS_HFCLKSTART = 1; | |||
| while (NRF_CLOCK->EVENTS_HFCLKSTARTED == 0) { } | |||
There was a problem hiding this comment.
Should this be disabled in .end()?
There was a problem hiding this comment.
I thought about this and it might not be clever (since BLE could be in use and would stop working on PDM.end() ).
There was a problem hiding this comment.
ok, so then should we check if it's already enabled before "restarting" it. I would also add a small comment to capture why end() doesn't disable to be kind to our future selves :)
There was a problem hiding this comment.
Agree on the comment for our future selves 😉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.