Skip to content

Improve first use experience for Upload before Port selected #7958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2018
Merged

Improve first use experience for Upload before Port selected #7958

merged 3 commits into from
Sep 3, 2018

Conversation

PaulStoffregen
Copy link
Contributor

Fixes #7943

When running the IDE for the first time, this appears if Upload is attempted before selecting a Port.

capture

matthijskooijman
matthijskooijman reviewed Aug 31, 2018
View reviewed changes
matthijskooijman
matthijskooijman approved these changes Aug 31, 2018
View reviewed changes
Copy link
Collaborator

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. For the final merge, it would make sense to squash that last commit into the first one, though.

@PaulStoffregen
Copy link
Contributor Author

PaulStoffregen commented Aug 31, 2018 •
edited
Loading

Looked at this just a little more. UploaderFactory seems to handle a null boardPort well. It's only used for network uploaders. It checks for null and those aren't considered if it's null. It's not used for SerialUploader, so null is ok.

@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7958-BUILD-768-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7958-BUILD-768-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7958-BUILD-768-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7958-BUILD-768-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7958-BUILD-768-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@cmaglie cmaglie added this to the Release 1.8.7 milestone Sep 3, 2018
@arduino arduino deleted a comment from ArduinoBot Sep 3, 2018
@cmaglie cmaglie merged commit e6bf0f2 into arduino:master Sep 3, 2018
@PaulStoffregen PaulStoffregen deleted the default_port_name branch September 10, 2018 21:45
@facchinm facchinm mentioned this pull request Oct 4, 2018
Closed
@matthijskooijman matthijskooijman mentioned this pull request Nov 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthijskooijman matthijskooijman matthijskooijman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 1.8.7

Development

Successfully merging this pull request may close these issues.

4 participants

@PaulStoffregen @ArduinoBot @matthijskooijman @cmaglie