Skip to content

Fix OSX "slow" menus #7935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2018
Merged

Fix OSX "slow" menus #7935

merged 2 commits into from
Aug 28, 2018

Conversation

facchinm
Copy link
Member

JRE 8u161 made JMenu.insert() MUCH slower on OSX.
This exposed a bug lurking there for years; in fact the menu entries were rebuilt every time since JMenu.getComponent() returns an empty list.
The correct function is JMenu.getMenuComponents()
In the meantime, also remove sketchbookMenu and examplesMenu deletion on board change; only their content needs to be updated, not the container itself.

Fixes #7924

@facchinm
Fix check for wrong submenu
49cd9b5
@facchinm
Fix rebuild being triggered on every menu open()
2f3a561 
Fixes arduino#7924

JRE 8u161 made JMenu.insert() MUCH slower on OSX.
This exposed a bug lurking there for years; in fact the menu entries were rebuilt every time since JMenu.getComponent() returns an empty list.
The correct function is JMenu.getMenuComponents().
In the meantime, also remove sketchbookMenu and examplesMenu being deleted on board change; only their content needs to be updated, not the container itself.
@facchinm facchinm requested a review from cmaglie August 27, 2018 14:28
@facchinm facchinm mentioned this pull request Aug 27, 2018
Closed
@facchinm facchinm added this to the Release 1.8.7 milestone Aug 27, 2018
@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7935-BUILD-760-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7935-BUILD-760-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7935-BUILD-760-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7935-BUILD-760-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7935-BUILD-760-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@DrDiodac
Copy link

DrDiodac commented Aug 28, 2018 via email

@PaulStoffregen
Copy link
Contributor

PaulStoffregen commented Aug 28, 2018 •
edited
Loading

If you find any problem that only happens with Teensy, but doesn't occur with official Arduino boards, please report it on the PJRC Forum, not here. I'll reply there and work on a fix.

This tracker is only for Arduino issues.

And just to confirm, there is an unrelated Teensyduino bug where the Ports menu is experiencing lag on some Macintosh computers. I am working on fix. The last thing I want to do is cause confusion or extra work for the Arduino developers, in this unfortunate situation of entirely different issues that manifest with similar symptoms.

@facchinm facchinm merged commit bf42f26 into arduino:master Aug 28, 2018
@cmaglie cmaglie deleted the fix_osx_slow_menus branch August 28, 2018 15:50
@PaulStoffregen PaulStoffregen mentioned this pull request Oct 21, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmaglie cmaglie cmaglie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 1.8.7

Development

Successfully merging this pull request may close these issues.

5 participants

@facchinm @ArduinoBot @DrDiodac @PaulStoffregen @cmaglie