Simplify header file a bit #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it and it works I'm merging it! Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some of the nested platform
#ifdefstatements and uses platform specific constants for endpoint size as the midi buffer size.When used with arduino/ArduinoCore-samd#102, Windows 8 reports the a Zero board as a sound device in the device manager (512 was being used as the MIDI buffer size, now 64 is used on SAMD). This might help resolve #8 when used with the SAMD PR. We still need to try it out with a MIDI program.
I've also removed the wildcard value for architectures in
library.properties.cc/ @agdl @facchinm