Fix crash when Arduino_RouterBridge is included but begin() not called #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: monitor._read mux unlock
fix: monitor trying to connect even if bridge begin fails + monitor._read is private mod: implementation is Arduino only, better mux usage
gbr1
approved these changes
Aug 6, 2025
Collaborator
gbr1
left a comment
gbr1
left a comment
There was a problem hiding this comment.
LGTM, tested with various scenarios
eigen-value
approved these changes
Aug 6, 2025
src/monitor.h
Outdated
| bool begin() { | ||
| return bridge.call(MON_CONNECTED_METHOD, is_connected); | ||
| k_mutex_init(&monitor_mutex); | ||
| if (!bridge) { |
Collaborator
There was a problem hiding this comment.
I think bridge should be dereferenced first:
(!(*bridge))
otherwise the bool operator is not invoked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.