mod: minor bridge. monitor._read as void

fix: monitor._read mux unlock

Author: eigen-value

src/bridge.h

@@ -46,7 +46,7 @@ class BridgeClass {
 
 public:
 
-    BridgeClass(HardwareSerial& serial) {
+    explicit BridgeClass(HardwareSerial& serial) {
         serial_ptr = &serial;
     }
 
@@ -234,7 +234,7 @@ class BridgeClassUpdater {
 
 BridgeClass Bridge(Serial1);
 
-void updateEntryPoint(void *, void *, void *){
+inline void updateEntryPoint(void *, void *, void *){
     while (true) {
         if (Bridge) {
             Bridge.update();
@@ -247,7 +247,7 @@ static void safeUpdate(){
     BridgeClassUpdater::safeUpdate(&Bridge);
 }
 
-void __loopHook(){
+inline void __loopHook(){
     k_msleep(1);
     safeUpdate();
 }

src/monitor.h

@@ -34,7 +34,7 @@ class BridgeMonitor: public Stream {
     bool is_connected = false;
 
 public:
-    BridgeMonitor(BridgeClass& bridge): bridge(&bridge) {}
+    explicit BridgeMonitor(BridgeClass& bridge): bridge(&bridge) {}
 
     using Print::write;
 
@@ -46,7 +46,7 @@ class BridgeMonitor: public Stream {
         return bridge->call(MON_CONNECTED_METHOD, is_connected);
     }
 
-    operator bool() const {
+    explicit operator bool() const {
         return is_connected;
     }
 
@@ -119,9 +119,9 @@ class BridgeMonitor: public Stream {
         return (ok && res);
     }
 
-    int _read(size_t size) {
+    void _read(size_t size) {
 
-        if (size == 0) return 0;
+        if (size == 0) return;
 
         MsgPack::arr_t<uint8_t> message;
         bool ret = bridge->call(MON_READ_METHOD, message, size);
@@ -131,15 +131,13 @@ class BridgeMonitor: public Stream {
             for (size_t i = 0; i < message.size(); ++i) {
                 temp_buffer.store_char(static_cast<char>(message[i]));
             }
-            return message.size();
         }
 
         // if (bridge.lastError.code > NO_ERR) {
         //     is_connected = false;
         // }
-        k_mutex_unlock(&monitor_mutex);
-        return 0;
 
+        k_mutex_unlock(&monitor_mutex);
     }