fix: Monitor begin alone crashes. mod: minor UNDER TESTING

Author: eigen-value

src/bridge.h

@@ -33,7 +33,7 @@ class BridgeClass {
     RPCClient* client = nullptr;
     RPCServer* server = nullptr;
     HardwareSerial* serial_ptr = nullptr;
-    ITransport* transport;
+    ITransport* transport = nullptr;
 
     struct k_mutex read_mutex;
     struct k_mutex write_mutex;
@@ -48,16 +48,16 @@ class BridgeClass {
 
     BridgeClass(HardwareSerial& serial) {
         serial_ptr = &serial;
-        transport = new SerialTransport(serial);
     }
 
-    operator bool() const {
+    explicit operator bool() const {
         return started;
     }
 
     // Initialize the bridge
     bool begin(unsigned long baud=DEFAULT_SERIAL_BAUD) {
         serial_ptr->begin(baud);
+        transport = new SerialTransport(*serial_ptr);
 
         k_mutex_init(&read_mutex);
         k_mutex_init(&write_mutex);
@@ -175,11 +175,11 @@ class BridgeClass {
     }
 
     String get_error_message() const {
-        return (String) client->lastError.traceback;
+        return static_cast<String>(client->lastError.traceback);
     }
 
     uint8_t get_error_code() const {
-        return (uint8_t) client->lastError.code;
+        return static_cast<uint8_t>(client->lastError.code);
     }
 
 private:
@@ -235,7 +235,7 @@ class BridgeClassUpdater {
 BridgeClass Bridge(Serial1);
 
 void updateEntryPoint(void *, void *, void *){
-    while (1) {
+    while (true) {
         if (Bridge) {
             Bridge.update();
         }

src/monitor.h

@@ -36,9 +36,11 @@ class BridgeMonitor: public Stream {
 public:
     BridgeMonitor(BridgeClass& bridge): bridge(&bridge) {}
 
+    using Print::write;
+
     bool begin() {
         k_mutex_init(&monitor_mutex);
-        if (!bridge) {
+        if (!(*bridge)) {
             bridge->begin();
         }
         return bridge->call(MON_CONNECTED_METHOD, is_connected);
@@ -80,6 +82,7 @@ class BridgeMonitor: public Stream {
             return temp_buffer.peek();
         }
         k_mutex_unlock(&monitor_mutex);
+        return -1;
     }
 
     size_t write(uint8_t c) override {
@@ -92,7 +95,7 @@ class BridgeMonitor: public Stream {
 
         for (size_t i = 0; i < size; ++i) {
 #ifdef ARDUINO
-            send_buffer += (char)buffer[i];
+            send_buffer += static_cast<char>(buffer[i]);
 #else
             send_buffer.push_back(static_cast<char>(buffer[i]));
 #endif
@@ -116,15 +119,6 @@ class BridgeMonitor: public Stream {
         return (ok && res);
     }
 
-    size_t write(String message) {
-        size_t size;
-        bool ok = bridge->call(MON_WRITE_METHOD, size, message);
-
-        if (!ok) return 0;
-
-        return size;
-    }
-
     int _read(size_t size) {
 
         if (size == 0) return 0;