-
Notifications
You must be signed in to change notification settings - Fork 0
Added sketch compile workflow #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a82e543
to
3268332
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You removed the platform dependency information in 3268332
(#7).
That jobs.<job_id>.strategy.matrix.include
system is useful to avoid code duplication in the workflow when the same relatively complex configuration is present for multiple compilation targets (I provide a detailed explanation here), but is fairly unintuitive and significantly increases the complexity of the workflow. So it is definitely reasonable to eschew it in this case. However, if you are going to do that then you must define the platform dependency of the target in strategy.matrix.board[*].platform
. You can see an example of that approach in the canonical "template" workflow:
3268332
to
98bf0a9
Compare
Even if the tests are failing, the workflow is ready to go. I'm going to merge it so that the remaining warnings/errors can be fixed in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the explanation @per1234. In this case, the dependency tree is very simple and straightforward, but good to know for future projects! |
Added sketch compile workflow to build examples for a bunch of boards.
Copied and adapted from https://github.com/arduino-libraries/Arduino_NetworkConfigurator/blob/main/.github/workflows/compile-examples.yml