Skip to content

Added arduino-lint check workflow #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 9, 2025
Merged

Added arduino-lint check workflow #6

merged 8 commits into from
May 9, 2025

Conversation

cmaglie
Copy link
Contributor

@cmaglie cmaglie commented May 8, 2025

Related to #2

@cmaglie
Copy link
Contributor Author

cmaglie commented May 8, 2025

There is a warning remaining that will fix itself once the repo is published.

WARNING: Unable to load the library.properties url field: 404 Not Found                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP042)

@cmaglie cmaglie requested a review from eigen-value May 8, 2025 15:25
per1234
per1234 reviewed May 8, 2025
View reviewed changes
@per1234 per1234 added type: imperfection Perceived defect in any part of project type: enhancement Proposed improvement topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure labels May 8, 2025
cmaglie and others added 6 commits May 8, 2025 18:25
@cmaglie
Added arduino-lint check workflow
7bde1a3
@cmaglie
Change library-manager checks to 'submit'
21b270b 
it will be changed back to 'update' once the library is published.
@cmaglie
Fix linter warning
fd75392 
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy
         is not needed.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP036)
@cmaglie
Renamed lib to Arduino_RPClite
0530795 
WARNING: Library name RPClite is missing the "Arduino_" prefix. The names of all new official libraries must have this
         prefix.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP013)
@cmaglie @per1234
Update .github/workflows/arduino-lint.yml
cf07b08 
Co-authored-by: Per Tillisch <[email protected]>
@cmaglie
Set strict compliance for the linter
01947e9
@cmaglie cmaglie force-pushed the add_arduino_lint_wfl branch from 045e398 to 01947e9 Compare May 8, 2025 16:25
per1234
per1234 approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cristian!

@cmaglie
Copy link
Contributor Author

cmaglie commented May 8, 2025

I see that the URL in the url field is not available yet; this is reported as an error, but it won't change until we publish the library.
I'm going to put a placeholder link for now, we must remember to set it to a proper URL before we publish.

eigen-value
eigen-value reviewed May 9, 2025
View reviewed changes
eigen-value
eigen-value requested changes May 9, 2025
View reviewed changes
Copy link
Collaborator

@eigen-value eigen-value left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor changes needed in library.properties

eigen-value
eigen-value approved these changes May 9, 2025
View reviewed changes
Copy link
Collaborator

@eigen-value eigen-value left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cmaglie that is very helpful!

@eigen-value eigen-value merged commit afb3811 into main May 9, 2025
2 checks passed
@cmaglie cmaglie deleted the add_arduino_lint_wfl branch May 12, 2025 09:00
@cmaglie cmaglie mentioned this pull request May 28, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eigen-value eigen-value eigen-value approved these changes

+1 more reviewer

@per1234 per1234 per1234 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmaglie @per1234 @eigen-value