Skip to content

Cleanup #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 6, 2025
Merged

Cleanup #28

merged 9 commits into from
Aug 6, 2025

Conversation

@eigen-value
Copy link
Collaborator

@eigen-value eigen-value commented Aug 4, 2025 •
edited
Loading

this PR features:

  • improved readability
  • type check on bound callback parameters. If type is wrong server returns a MALFORMED_CALL_ERR with err message pointing to the wrong parameter
  • parameters passing optimization
  • decoders buffer size as lib parameter
  • transport max no. is now a lib parameter

@eigen-value eigen-value requested a review from gbr1 August 4, 2025 17:29
@per1234 per1234 linked an issue Aug 5, 2025 that may be closed by this pull request
RPC calls type check #18
Closed
@per1234 per1234 added type: imperfection Perceived defect in any part of project type: enhancement Proposed improvement topic: code Related to content of the project itself labels Aug 5, 2025
gbr1
gbr1 approved these changes Aug 6, 2025
View reviewed changes
Copy link
Collaborator

@gbr1 gbr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eigen-value eigen-value merged commit becc113 into development Aug 6, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gbr1 gbr1 gbr1 approved these changes

Assignees

No one assigned

Labels

topic: code Related to content of the project itself type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RPC calls type check

4 participants

@eigen-value @gbr1 @per1234