This repository was archived by the owner on Jul 3, 2020. It is now read-only.
Make some final fixes #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljmf00
requested review from
DReigada,
andreaTP,
bmbferreira,
gjsduarte,
lolgab,
mrfyda,
pedrocodacy and
rtfpessoa
Signed-off-by: Luís Ferreira <[email protected]>
ljmf00
force-pushed
the
luis-ferreira/hotfix-useless-async
branch
from
b1bff63 to
dfa5669
Compare
ljmf00
changed the title
Signed-off-by: Luís Ferreira <[email protected]>
Signed-off-by: Luís Ferreira <[email protected]>
ljmf00
force-pushed
the
luis-ferreira/hotfix-useless-async
branch
from
4d772f9 to
c76ede5
Compare
lolgab
approved these changes
Sep 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an hotfix for tool not sending the coverage request due to an async Task. I just removed that and keept that synchronous.
It also fixes the api endpoint for final report and add missing parameter to README.