Skip to content
This repository was archived by the owner on Jul 3, 2020. It is now read-only.

Conversation

@pamidur
Copy link

@pamidur pamidur commented Nov 15, 2019

The problem

My CI build is executed like this

./codacy -c $HASH -t $TOKEN -r $coverage_file -e opencover

and I forgot to set the $TOKEN, the result however is successful

Codacy.CSharpCoverage 1.0.0
Copyright (C) 2019 Codacy.CSharpCoverage

ERROR(S):
  Option 't, token' has no value.
  Required option 't, token' is missing.

> echo $?
0

The solution

Make the app return status code 1 when there were command line parsing errors

Copy link
Contributor

@ljmf00 ljmf00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pamidur ,

Thank you for your great contribution! The patch seems good to go.

Cheers,
Luis

@ljmf00 ljmf00 merged commit ce8a56c into archived-codacy:master Nov 18, 2019
@pamidur pamidur deleted the exit-codes branch November 19, 2019 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants