This repository was archived by the owner on Jul 3, 2020. It is now read-only.
made publish use trimming and warp pack #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamidur
requested review from
DReigada,
andreaTP,
bmbferreira,
ljmf00,
lolgab,
pedrocodacy and
rtfpessoa
as code owners
Contributor
|
Hey @pamidur , Thank you for your great contribution! The patch seems good to go. Cheers, |
ljmf00
approved these changes
Nov 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow the output single file to be much smaller. It is very important for scenarios when you build your app in one-time-use docker container. Downloading 70 megs takes a lot of time!
