Skip to content
This repository was archived by the owner on Jul 3, 2020. It is now read-only.

Conversation

@pamidur
Copy link

@pamidur pamidur commented Nov 14, 2019

The problem

On machines with non-US culture the app fails with an exception:

Unhandled Exception: System.FormatException: Input string was not in a correct format.
   at System.Number.ParseDouble(ReadOnlySpan`1 value, NumberStyles options, NumberFormatInfo numfmt)
   at Codacy.CSharpCoverage.Parsing.Processors.OpenCoverProcessor.Parse(String file)
   at Codacy.CSharpCoverage.Program.<>c.<Main>b__0_0(Options opt)
   at CommandLine.ParserResultExtensions.WithParsed[T](ParserResult`1 result, Action`1 action)
   at Codacy.CSharpCoverage.Program.Main(String[] args)

The solution

Make double parsing culture invariant

Copy link

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the interest in the project and thanks for the patch!

@ljmf00 ljmf00 merged commit 7402c5a into archived-codacy:master Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants