-
Notifications
You must be signed in to change notification settings - Fork 4
[GA-153-1] Implement EdgeAttrDict update method (new) #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hkernbach I'm just realizing now that in order for users to do something like this: G.adj.update(...) We'll need to create a So similar to the setup we have for NetworkX doesn't recommend users to directly access the This will warrant creating a |
Please let's discuss this next. This is not yet clear to me |
nx_arangodb/classes/function.py
Outdated
if ( | ||
graph_type == GraphType.Graph.name | ||
or graph_type == GraphType.DiGraph.name | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we extract this boolean check out of the double for loop given that graph_type
is constant throughout this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in da332e0
Co-authored-by: Anthony Mahanna <[email protected]>
Co-authored-by: Anthony Mahanna <[email protected]>
Co-authored-by: Anthony Mahanna <[email protected]>
Co-authored-by: Anthony Mahanna <[email protected]>
This PR replaces: #15