-
Notifications
You must be signed in to change notification settings - Fork 73
[Bugfix] Add Arch Toleration #1961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for architecture tolerations in Kubernetes pods to handle node architecture taints. The change ensures pods can be scheduled on nodes with different architectures by adding a toleration for the kubernetes.io/arch
taint.
- Introduces a new
TolerationArchitecture
constant andNewNoScheduleToleration
helper function - Adds architecture tolerations to pod creation logic and image update pods
- Updates Helm chart templates to include the architecture toleration
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
pkg/util/k8sutil/tolerations/tolerations.go | Adds architecture toleration constant and new NoSchedule toleration helper function |
pkg/deployment/resources/pod_creator_tolerations.go | Integrates architecture toleration into pod creation |
pkg/deployment/images_test.go | Updates test tolerations to include architecture toleration |
pkg/deployment/images.go | Adds architecture toleration to image update pods |
chart/*/templates/deployment.yaml | Updates Helm chart templates to include architecture toleration |
CHANGELOG.md | Documents the new feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Key: key, | ||
Operator: "Exists", | ||
Effect: "NoExecute", | ||
Effect: core.TaintEffectNoExecute, |
Copilot
AI
Aug 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change modifies existing behavior by replacing the string literal 'NoExecute' with the constant core.TaintEffectNoExecute. While this is generally a good practice, it should be verified that this doesn't break any existing functionality that might depend on the string comparison.
Copilot uses AI. Check for mistakes.
- (Feature) Chart By Tag filter | ||
- (Feature) Add Gateway Config condition | ||
- (Bugfix) Fix AnyPB Parsing in Meta Service | ||
- (Feature) Add Arch Tolerations |
Copilot
AI
Aug 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The changelog entry uses 'Arch' as an abbreviation. Consider using the full word 'Architecture' for clarity: '- (Feature) Add Architecture Tolerations'
- (Feature) Add Arch Tolerations | |
- (Feature) Add Architecture Tolerations |
Copilot uses AI. Check for mistakes.
No description provided.