Skip to content

Conversation

@ajanikow
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed label Aug 19, 2025
@ajanikow ajanikow requested a review from Copilot August 19, 2025 10:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes AnyPB (Any Protocol Buffer) parsing in the Meta Service by refactoring how protocol buffer Any types are handled in JSON serialization/deserialization.

  • Replaces the custom ugrpc.GRPC wrapper with a direct ObjectProto struct for better JSON compatibility
  • Adds comprehensive test coverage for JSON marshaling/unmarshaling of objects containing AnyPB
  • Updates the implementation to use direct field access instead of wrapper methods

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
integrations/meta/v1/object.go Refactors Object struct to use ObjectProto instead of ugrpc.GRPC wrapper
integrations/meta/v1/impl.go Updates Set method to access Object field directly
integrations/meta/v1/service_test.go Adds test for JSON serialization roundtrip
CHANGELOG.md Documents the bugfix in changelog

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ajanikow ajanikow merged commit 33c2c03 into master Aug 19, 2025
3 checks passed
@ajanikow ajanikow deleted the feature/fix_any_pb_parsing branch August 19, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants