Skip to content

[Feature] [Platform] Packer #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025
Merged

[Feature] [Platform] Packer #1915

merged 2 commits into from
Jul 1, 2025

Conversation

ajanikow
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jun 19, 2025
@ajanikow ajanikow force-pushed the feature/platform/packer branch 3 times, most recently from 96efb5f to cfb075a Compare June 23, 2025 15:12
@ajanikow ajanikow marked this pull request as ready for review June 23, 2025 16:10
@ajanikow ajanikow requested a review from Copilot June 23, 2025 16:10
Copilot

This comment was marked as outdated.

@ajanikow ajanikow force-pushed the feature/platform/packer branch from cfb075a to 595682d Compare June 30, 2025 18:01
@ajanikow ajanikow requested a review from Copilot July 1, 2025 07:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new feature for Platform Packer, introducing several refactorings and API improvements. Key changes include a revamped GetConfigMap function that now accepts variadic parts and uses a join‑based naming scheme, the introduction of generic functions (e.g. NewMergeValues[T any]), and the removal/refactoring of legacy platform command files. The changes affect many files—from utilities and platform APIs to tests—aiming for cleaner, more modular code as well as improved command-line interface functionalities.

Reviewed Changes

Copilot reviewed 76 out of 78 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/util/tests/suite/config_map.go Updated GetConfigMap to accept multiple parts and join them into a new config map name.
pkg/util/kclient/external/external.go Replaced direct os.LookupEnv use with a util.EnvironmentVariable constant.
pkg/util/k8sutil/helm/values.go Introduced a generic version of NewMergeValues to support any type.
pkg/platform/package.go Added a Validate() method that currently returns nil, and integrated the new Chart field into PackageSpec.
... (plus many other files with refactorings and API updates) ...
Comments suppressed due to low confidence (2)

pkg/util/tests/suite/config_map.go:38

  • The new naming convention in GetConfigMap concatenates parts with a '-' separator; please ensure that this approach does not lead to collisions if any part already contains hyphens.
func GetConfigMap(t *testing.T, k8s kubernetes.Interface, namespace string, parts ...string) *ConfigMap {

pkg/platform/package.go:37

  • The Validate method currently always returns nil; if no validation is needed, add commentary to clarify the design decision, or consider implementing validation logic if appropriate.
	}

@ajanikow ajanikow merged commit 0ef91ff into master Jul 1, 2025
3 checks passed
@ajanikow ajanikow deleted the feature/platform/packer branch July 1, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants