Skip to content

Internal protocol conformance can be stripped by accident #1061

@thomasvl

Description

@thomasvl

Trying to sync in current HEAD to google, we're seeing some of the new tests adding when addressing #1048 fail on linux with a compiler that is close to HEAD. I'm guessing that means compiler bug, but we haven't gotten a chance to dig.

Tests/SwiftProtobufTests/Test_JSON_Conformance.swift:151: error: Test_JSON_Conformance.testNullSupport_oneofNullValue : XCTAssertNotEqual failed: ("SwiftProtobufTests.ProtobufTestMessages_Proto3_TestAllTypesProto3:
") is equal to ("SwiftProtobufTests.ProtobufTestMessages_Proto3_TestAllTypesProto3:
") - 
Tests/SwiftProtobufTests/Test_JSON_Conformance.swift:160: error: Test_JSON_Conformance.testNullSupport_oneofNullValue : XCTAssertEqual failed: ("{}") is not equal to ("{"oneofNullValue":null}") - 
Tests/SwiftProtobufTests/Test_JSON_Conformance.swift:167: error: Test_JSON_Conformance.testNullSupport_oneofNullValue : XCTAssertEqual failed: ("[]") is not equal to ("[192, 7, 0]") - 
Tests/SwiftProtobufTests/Test_JSON_Conformance.swift:211: error: Test_JSON_Conformance.testNullSupport_repeatedNullValue : failed - Decode failed with error illegalNull: {"repeatedNullValue": [0, "NULL_VALUE", null]}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions