Enable strict concurrency checking in CI #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
approved these changes
Aug 11, 2023
Contributor
Author
|
@glbrntt My original PR only tested on macOS, and didn't fix tests. Now both Linux and tests are fixed up, the diff is a little larger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To further avoid concurrency bugs, enable complete concurrency checking in CI.
Modifications
Added the compiler flag to the docker-compose scripts.
Result
If a warning of this nature comes up, because we have warnings-as-errors, it'll fail CI.
Test Plan
Locally built without any warnings with the flag enabled.