Skip to content

Conversation

@czechboy0
Copy link
Contributor

@czechboy0 czechboy0 commented Nov 20, 2023

Motivation

Add the public types approved in SOAR-0009.

Modifications

Added the public types and make other changes outlined in SOAR-0009.

Result

Most of the required runtime types are now in place.

Test Plan

Added unit tests for the new code, where it made sense.

⚠️ The pipeline pull request validation (api breakage) is failing with:

1 breaking change detected in OpenAPIRuntime:
  💔 API breakage: constructor Configuration.init(dateTranscoder:) has removed default argument from parameter 0
** ERROR: ❌ Breaking API changes detected.

but that seems to be a false positive in the tool, as there is now a newer initializer that you can use as .init(), .init(dateTranscoder:), .init(multipartBoundaryGenerator:), or init(dateTranscoder:multipartBoundaryGenerator:), so no existing code could be broken by this change.

@czechboy0 czechboy0 marked this pull request as ready for review November 20, 2023 16:31
Copy link
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, otherwise LGTM.

@simonjbeaumont
Copy link
Collaborator

LGTM, feel free to land once you appease the CI (probably my bad suggestions causing formatting complaints; didn't check). I guess you'll need to merge over the API checker, which you said is a false positive.

@czechboy0 czechboy0 merged commit 5060bb9 into apple:main Nov 24, 2023
@czechboy0 czechboy0 deleted the hd-multipart-body branch November 24, 2023 10:47
@czechboy0 czechboy0 added 🔨 semver/patch No public API change. 🆕 semver/minor Adds new public API. and removed 🔨 semver/patch No public API change. labels Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🆕 semver/minor Adds new public API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants