Skip to content

Conversation

tib
Copy link
Contributor

@tib tib commented Oct 23, 2023

This pull request aims to fix the server tutorial sample code.
Sample snippets updated to use Swift 5.9 and Swift OpenAPI generator tools 0.3.0+

@czechboy0
Copy link
Contributor

This is great, @tib, thank you!

Would you be open to also updating the other 2 tutorials, to keep all 3 in sync?

@czechboy0
Copy link
Contributor

@swift-server-bot add to allowlist

@czechboy0 czechboy0 linked an issue Oct 23, 2023 that may be closed by this pull request
@tib
Copy link
Contributor Author

tib commented Oct 23, 2023

This is great, @tib, thank you!

Would you be open to also updating the other 2 tutorials, to keep all 3 in sync?

Yes, of course I can do that, do you want me to open separate PRs or alter this one?

@czechboy0
Copy link
Contributor

This is great, @tib, thank you!
Would you be open to also updating the other 2 tutorials, to keep all 3 in sync?

Yes, of course I can do that, do you want me to open separate PRs or alter this one?

You can do it in this one.

@czechboy0
Copy link
Contributor

Ok with https://github.com/apple/swift-openapi-runtime/releases/tag/0.3.4 released, please see if you can simplify the example and it actually works for you :)

@tib
Copy link
Contributor Author

tib commented Oct 24, 2023

Ok with https://github.com/apple/swift-openapi-runtime/releases/tag/0.3.4 released, please see if you can simplify the example and it actually works for you :)

let emoji = String(emojis.randomElement()!)
return .ok(.init(body: .plainText(.init(emoji))))

I already changed that. 😉

@czechboy0 czechboy0 merged commit 193989e into apple:main Oct 24, 2023
@czechboy0 czechboy0 added the semver/none No version bump required. label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server tutorial has outdated syntax

2 participants