Fix flakiness in testWithConfiguredStreamSocket #3399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This test occasionally fails in our ongoing continuous CI solution. Flaky tests are bad, and we should aim not to have them, so let's fix it.
My diagnosis of the most likely race here (which leads to
alreadyClosed) being thrown somewhere from this code is that the client channel got closed unexpectedly. This would happen if an unusual series of events occurs:Modifications:
Add a ConditionLock we can use to wait for a connection to be established.
Make the use of this ConditionLock resilient to weird test behaviour by always using timeouts for blocking operations.
Result:
Less flaky tests.