This repository was archived by the owner on Apr 2, 2020. It is now read-only.
[Do not merge yet][SE-0101] Migration #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
|
||
| func doSomething(b: Int) { | ||
| a += strideof(b.dynamicType) //% self.expect("expr a", substrs=['Int', '= 1']) | ||
| a += MemoryLayout.of(b).stride //% self.expect("expr a", substrs=['Int', '= 1']) |
Member
Author
There was a problem hiding this comment.
Actually this stride value means nothing here.
We might want to use simpler expression? e.g. a += 42
Collaborator
There was a problem hiding this comment.
I asked Jim and Sean about this test, and they suggested that we use a += b, as long as the test continues to pass.
Collaborator
|
Continuing in #39. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on swiftlang/swift#3854
SE-0101 removes
sizeof,sizeofValueand related functions from the stdlib.This PR is migrating them to newly introduced
MemoryLayout<T>values.