This repository was archived by the owner on Apr 2, 2020. It is now read-only.
Adapt lldb to the new swift weak reference representation. #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<rdar://problem/29765836>
Contributor
|
@swift-ci please test |
Contributor
|
@swift-ci please test |
1 similar comment
Contributor
|
@swift-ci please test |
Member
|
Ping? This is broken in shipping releases of Xcode. |
Contributor
|
@jimingham what's the status of this? Happy to chat with you and put in my work queue as this seems very serious and Slava/others are blocked on it. |
Contributor
|
@gparker42 can we have a chat about this? I feel really bad that this has been really broken for a while and nobody on the debugger side picked this up. I'd love to get this resolved sooner rather than later. |
Contributor
|
This was superseded by #152, which was fixed and closed almost a year ago. If weak references are still not working in lldb then you should file a new bug report. |
Contributor
|
@gparker42 thanks for the update! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adapting lldb to the new swift weak reference representation. This pull request depends on changes from Greg Parker, so he's going to make the changes on his side and then do a joint test.
rdar://problem/29765836