This repository was archived by the owner on Apr 2, 2020. It is now read-only.
Cherry pick changes to the 5.1 branch #1377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Address_Enum() These two functions are identical, and don't do anything specific to structs or enums, so let's combine them into one more general function.
It's not really correct to unwrap existentials in tuple elements because the resulting concrete tuple type has a different layout than the original type. This changes some test output but note that the old behavior was inconsistent; we would only call GetDynamicTypeAndAddress_Tuple() if the original type was already generic, so a type like (Error, T) for a generic parameter 'T' would unwrap the Error payload, whereas a type like (Error, Int) would not.
Member
|
great! |
Member
|
@swift-ci test |
Member
Author
|
@adrian-prantl I haven't tested this locally yet. It might not even compile. I'm on it, don't worry. |
…rorValue() Existentials are represented as addresses of values, so a Swift error existential should be the address of a pointer to an Error container and not a pointer to the Error container itself.
…amicTypeAndAddress_Class()
… substitution This will allow us to completely eliminate the generic parameter path.
…generic parameters This will allow a corresponding simplification on the IRGen side, since we no longer need to emit debug info for dependent member types.
They were actually unnecessary and doing the wrong thing when we had generic parameters wrapping existentials.
Member
Author
|
@swift-ci Please test |
Member
Author
|
Should be fixed now |
Member
Author
|
Ok, I need to cherry-pick some RemoteAST fixes to swift-5.1-branch on the Swift side too. |
Member
Author
|
swiftlang/swift#23285 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.