Skip to content
This repository was archived by the owner on Jul 11, 2025. It is now read-only.

Add OTel messaging attributes #26

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Add OTel messaging attributes #26

merged 1 commit into from
Feb 6, 2023

Conversation

slashmo
Copy link
Contributor

@slashmo slashmo commented Feb 3, 2023

@slashmo slashmo requested a review from ktoso February 3, 2023 18:10
@slashmo
Copy link
Contributor Author

slashmo commented Feb 3, 2023

@ktoso / @yim-lee There seem to be general issues with the CI going on. I don't think it's related to this PR:

[2/9] RUN apt-get update && apt-get install -y locales locales-all:
#0 0.131 runc run failed: unable to start container process: error during container init: error preparing rootfs: mount /var/lib/docker/1001.1001/buildkit/executor/ynpqjescspxaeb1xoi8aomemq/rootfs:/var/lib/docker/1001.1001/buildkit/executor/ynpqjescspxaeb1xoi8aomemq/rootfs, flags: 0x5000: permission denied

@yim-lee
Copy link
Member

yim-lee commented Feb 3, 2023

@slashmo Yeah, seeing the issue in apple/swift-nio#2362 too

@yim-lee
Copy link
Member

yim-lee commented Feb 3, 2023

@swift-server-bot test this please

ktoso
ktoso approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you @slashmo!

@ktoso ktoso merged commit 8841fda into apple:main Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@ktoso ktoso ktoso approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OTel semantic attributes: Messaging Systems
3 participants
@slashmo @yim-lee @ktoso