This repository was archived by the owner on Jul 11, 2025. It is now read-only.
README update #17
Merged
README update #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-readme
branch
2 times, most recently
from
1267e0a to
9bff871
Compare
slashmo
approved these changes
Jul 25, 2022
README.md
Outdated
| span.attributes.http.method = exampleRequest.method | ||
| span.attributes.http.url = exampleRequest.url | ||
| // ... | ||
| span.attributes.http.request.headers = exampleRequest.headers |
There was a problem hiding this comment.
This wouldn't work the way I implemented headers. You can either set a specific header, e.g. span.attributes.http.request.headers.contentType = "application/json", or call a method on the headers attribute if you don't know the header names upfront.
There was a problem hiding this comment.
Right gottcha, I'll remove from the example snippet
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.