Don't insert space around either side of range operator #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `1...5` gets reformatted into `1 ... 5`. Modifications: Add swiftformat rule `--ranges no-space`. Result: swiftformat doesn't insert space around either side of the range operator.
yim-lee
commented
Aug 27, 2019
| --comments ignore | ||
| --ifdef no-indent | ||
| --patternlet inline | ||
| --ranges no-space |
Member
Author
There was a problem hiding this comment.
Added this.
The rest I put in alphabetical order.
```
/Users/ylee/apple/swift-distributed-actors/Samples/SampleMetrics/main.swift:83:23: error: ambiguous reference to member 'collect'
print(prom.collect())
^~~~
Prometheus.PrometheusClient:3:17: note: found this candidate
public func collect(_ succeed: (String) -> ())
^
Prometheus.PrometheusClient:4:17: note: found this candidate
public func collect(into promise: NIO.EventLoopPromise<String>)
^
Prometheus.PrometheusClient:5:17: note: found this candidate
public func collect(_ succeed: (NIO.ByteBuffer) -> ())
^
Prometheus.PrometheusClient:6:17: note: found this candidate
public func collect(into promise: NIO.EventLoopPromise<NIO.ByteBuffer>)
```
Copied from ac32225
Member
Author
|
Same build failure as mentioned in #40 (comment). Copied fix from ac32225 in the same PR. |
Member
Author
Member
|
I like this 👍 and evenmore so if it aligns with the google style guide, which supposedly is basically the stdlib guide. |
Member
|
Let's check with the others if we want to ensure we all use the same style or not etc. |
ktoso
approved these changes
Aug 27, 2019
Member
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
As far as I'm concerned this is nice 👍
let's see if others take issue with formatting ¯_(ツ)_/¯
Member
|
I prefer it with spaces, especially when using variables. Another thing that doesn't work without spaces is |
Member
Member
Author
|
Yep, let's not make this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
1...5gets reformatted into1 ... 5.Modifications:
Add swiftformat rule
--ranges no-space.Result:
swiftformat doesn't insert space around either side of the range operator.