Skip to content

Conversation

@ktoso
Copy link
Member

@ktoso ktoso commented Jan 26, 2020

Motivation:

We sometimes need to "fish for some message in a stream", i.e. only capture some messages that a probe receives.

This is most useful with the event stream on the cluster, e.g. "fish only for reachability changes"

Funnily enough the naming is adopted from Akka, not just our usual fishy puns :-)

Modifications:

  • add fishForMessages and fishFor(WhatType)

Result:

  • allows easy implementation of tests which need to only look as some cluster events (used a lot on cluster hardening work)

Copy link
Member

@yim-lee yim-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 Very handy!

@ktoso
Copy link
Member Author

ktoso commented Jan 27, 2020

Yup! Thanks for review <3

@ktoso ktoso merged commit 40d81d1 into apple:master Jan 27, 2020
@ktoso ktoso deleted the wip-fish-for-messages branch January 27, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants