Remove __secretlyKnownToBeLocal, adopt whenLocal #1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-server-bot test this please |
ktoso
reviewed
Mar 11, 2024
|
|
||
| for await event in system.cluster.events { | ||
| try __secretlyKnownToBeLocal.receiveClusterEvent(event) | ||
| try await self?.whenLocal { __secretlyKnownToBeLocal in |
There was a problem hiding this comment.
No need for the __secretlyKnownToBeLocal because whenLocal does bring the right isolation.
__secretlyKnownToBeLocal is a hack that turns off checking and we have to remove it.
ktoso
changed the title
|
@swift-server-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Calling
__secretlyKnownToBeLocalsomehow doesn't guarantee isolation and crashes sometimes (e.g. #1140). Not sure what exact issue though, but anyway it's better to callwhenLocal.Modifications:
Moved from calling
__secretlyKnownToBeLocaltowhenLocalwhere possible.Result: