-
Notifications
You must be signed in to change notification settings - Fork 79
Open
Labels
1 - triagedTicket makes sense and is well defined, ready to be worked onTicket makes sense and is well defined, ready to be worked onhelp wantedGreat tickets to get started contributing!Great tickets to get started contributing!size/SSmall task. (A couple of hours of work.)Small task. (A couple of hours of work.)
Description
the handshakes predate a lot of other things.
- They should use
ProtobufRepresentable(extend it) - the
system.serializationshould be used in TransportPipelines to serialize them, rather the raw serialization:
let bytes: ByteBuffer = try proto.serializedByteBuffer(allocator: context.channel.allocator)
// TODO: should we use the serialization infra ourselves here? I guess so...
Metadata
Metadata
Assignees
Labels
1 - triagedTicket makes sense and is well defined, ready to be worked onTicket makes sense and is well defined, ready to be worked onhelp wantedGreat tickets to get started contributing!Great tickets to get started contributing!size/SSmall task. (A couple of hours of work.)Small task. (A couple of hours of work.)