FAILED: ClusterLeaderActionsClusteredTests.test_down_to_removed_ensureRemovalHappensWhenAllHaveSeenDown

[yim-lee]

10:40:21 Test Case 'ClusterLeaderActionsClusteredTests.test_down_to_removed_ensureRemovalHappensWhenAllHaveSeenDown' started at 2020-02-21 18:40:21.973
10:40:26 /code/Tests/DistributedActorsTests/Cluster/ClusterLeaderActionsClusteredTests.swift:236: error: ClusterLeaderActionsClusteredTests.test_down_to_removed_ensureRemovalHappensWhenAllHaveSeenDown : XCTAssertTrue failed - 
10:40:26             eventsOnFirstSub.shouldContain(.snapshot(.empty))
10:40:26                               ^~~~~~~~~~~~~~
10:40:26 error: Expected Array<Event>:
10:40:26     snapshot(Membership(count: 1, leader: [.none], members: [Member(sact://first:1898847890@localhost:9001, status: joining, reachability: reachable)]))
10:40:26     membershipChange(sact://second@localhost:9002 :: [unknown] -> [joining])
10:40:26     leadershipChange(DistributedActors.Cluster.LeadershipChange(oldLeader: nil, newLeader: Optional(Member(sact://first:1898847890@localhost:9001, status: joining, reachability: reachable))))
10:40:26     membershipChange(sact://third@localhost:9003 :: [unknown] -> [joining])
10:40:26     membershipChange(sact://first@localhost:9001 :: [joining] -> [     up])
10:40:26     membershipChange(sact://second@localhost:9002 :: [joining] -> [     up])
10:40:26     membershipChange(sact://third@localhost:9003 :: [joining] -> [     up])
10:40:26     membershipChange(sact://second@localhost:9002 :: [     up] -> [   down])
10:40:26     membershipChange(sact://second@localhost:9002 :: [   down] -> [removed])
10:40:26 to contain: [snapshot(Membership(count: 0, leader: [.none], members: []))]
10:40:26 /code/Tests/DistributedActorsTests/Cluster/ClusterLeaderActionsClusteredTests.swift:237: error: ClusterLeaderActionsClusteredTests.test_down_to_removed_ensureRemovalHappensWhenAllHaveSeenDown : XCTAssertTrue failed - 
10:40:26             eventsOnFirstSub.shouldContain(.membershipChange(.init(node: first.cluster.node, fromStatus: nil, toStatus: .joining)))
10:40:26                               ^~~~~~~~~~~~~~
10:40:26 error: Expected Array<Event>:
10:40:26     snapshot(Membership(count: 1, leader: [.none], members: [Member(sact://first:1898847890@localhost:9001, status: joining, reachability: reachable)]))
10:40:26     membershipChange(sact://second@localhost:9002 :: [unknown] -> [joining])
10:40:26     leadershipChange(DistributedActors.Cluster.LeadershipChange(oldLeader: nil, newLeader: Optional(Member(sact://first:1898847890@localhost:9001, status: joining, reachability: reachable))))
10:40:26     membershipChange(sact://third@localhost:9003 :: [unknown] -> [joining])
10:40:26     membershipChange(sact://first@localhost:9001 :: [joining] -> [     up])
10:40:26     membershipChange(sact://second@localhost:9002 :: [joining] -> [     up])
10:40:26     membershipChange(sact://third@localhost:9003 :: [joining] -> [     up])
10:40:26     membershipChange(sact://second@localhost:9002 :: [     up] -> [   down])
10:40:26     membershipChange(sact://second@localhost:9002 :: [   down] -> [removed])
10:40:26 to contain: [membershipChange(sact://first@localhost:9001 :: [unknown] -> [joining])]

https://ci.swiftserver.group/job/swift-distributed-actors-swift51-p1rb/475/consoleFull

[ktoso]

Oh I see... I wonder if this is inherently racy, we dont know what exact snapshot we'd get here hm...

Will look at it tuesday

[ktoso]

This should be fixed now, had it on an until_failed for a long time now