Rename _CryptoExtras Take 2

[0xTim]

Following on from #281, opened as a new PR as the conflicts were too many

Checklist

• I've run tests to see all new and existing tests pass
• I've followed the code style of the rest of the project
• I've read the Contribution Guidelines
• I've updated the documentation if necessary

If you've made changes to gyb files

• I've run .script/generate_boilerplate_files_with_gyb and included updated generated files in a commit of this pull request

Motivation:

[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]

Modifications:

[Describe the modifications you've done.]

Result:

[After your change, what will change.]

[0xTim]

@Lukasa this was the GYB script removing all of the availability annotations - I'm not sure if this is intended or not

[Lukasa]

It's not, those annotations should stay.

[0xTim]

Do you want a separate issue for the gyb file? Looks like it hasn't been touched in a while since it was Python 2.7 up to now

[Lukasa]

Yes please. 😄

[Lukasa]

Thanks Tim, I'll review this shortly. I'm trying to get a catch-up merge to land to the wwdc-25 branch I'm afraid, and this patch will make that nearly impossible: do you mind rebuilding this shortly after that lands? #403

[0xTim]

Thanks Tim, I'll review this shortly. I'm trying to get a catch-up merge to land to the wwdc-25 branch I'm afraid, and this patch will make that nearly impossible: do you mind rebuilding this shortly after that lands? #403

Yep no problem

[Lukasa]

Ok, the branch is up-to-date, feel free to do the fixup.

[0xTim]

@Lukasa ok updated!

[Lukasa]

To minimise churn, can we add a _CryptoExtras module that only contains an @_exported import CryptoExtras? That will make it easier for folks to continue to support a wide range of versions of swift-crypto.

[0xTim]

To minimise churn, can we add a _CryptoExtras module that only contains an @_exported import CryptoExtras? That will make it easier for folks to continue to support a wide range of versions of swift-crypto.

Won't having a product named _CryptoExtras that points to the CryptoExtras target solve that?

[Lukasa]

I am...honestly not sure. Historically I've avoided wanting to do that to avoid any risk of the code being generated twice.

[0xTim]

Ok updated it, I tried to use it with JWTKit without the new module and the compiler fell over so looks like it is needed

[Lukasa]

This still needs a license header on it, strangely.

[Lukasa]

The format checker has some notes.

[Lukasa]

API breakage is expected, merging over it.