Skip to content

refactor!: Rename AppiumWebElement AppiumElement #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2021
Merged

refactor!: Rename AppiumWebElement AppiumElement #481

merged 5 commits into from
Oct 21, 2021

Conversation

TroyWalshProf
Copy link
Contributor

Change list

Rename AppiumWebElement AppiumElement

Types of changes

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

The name AppiumWebElement can be confusing as it suggest all Appium elements are only web elements.
Things will be clearer is we use the name AppiumElement instead.

@TroyWalshProf
Copy link
Contributor Author

Fixes #480
@akinsolb

@laolubenson laolubenson merged commit bf4b4a1 into appium:release/5.0.0 Oct 21, 2021
@mykola-mokhnach
Copy link

mykola-mokhnach commented Oct 21, 2021

I would rather implement this differently.
The old name should be marked as deprecated but PRESERVED and the new name should be added together with the old one, so users have some transition period to change their scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants