[fix] Fix that RSS is never returned on Windows #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jancurn
requested changes
May 3, 2021
index.js
Outdated
| if (process.platform == 'win32') { | ||
| // For Windows, WMIC.exe never returns any value for "Status" and it causes "WorkingSetSize" is set at columns[3] | ||
| // See: https://docs.microsoft.com/ja-jp/windows/win32/cimwin32prov/win32-process?redirectedfrom=MSDN | ||
| columns[4] = parseInt(columns[3], 10); |
There was a problem hiding this comment.
It would be safer to just skip "Status" in the WMIC call above. In case WMIC shows some non-empty string for it, this code here will fail.
pocesar
reviewed
May 3, 2021
|
@pocesar |
|
Merged and published, will get to Apify SDK soon - apify/crawlee#1017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSS is always returned as NaN, and I think it causes that the "mainProcessBytes" in the response of "Apify.getMemoryInfo" is always returned as "NaN" on Windows environment.