-
Notifications
You must be signed in to change notification settings - Fork 54
feat: Add deployment to smithery #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sadly breaks the DockerHub integration 🥲
"node": ">=18.0.0" | ||
}, | ||
"main": "dist/index.js", | ||
"module": "./src/smithery.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Info I get from LLM how to use main and module:
- main should point to the CommonJS build (usually in dist/).
- module should point to the ESM build (also in dist/), not to the TypeScript source.
- Both should export the same API.
- Ensure all referenced files are published.
The problem is that we have other exported APIs in the main and module. I think it will break our internal server if Typescript looks at the module and sees only Smithery, not ActorsMcpServer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for the late answer, as smithery deployment was deprioritized.
I'll fix it based on your comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not work at smithery, when I use:
"main": "dist/index.js",
"module": "dist/index.js",
#15 6.878 ❌ Build failed: Error: Entry file specified in package.json not found at /app/dist/index.js.
Because smithery is not building the project 🤷🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If some settings in Smithery are possible (like changing the root directory), we can create a directory with the package only for Smithery.
It looks like Smithery requirements are not compatible with normal package usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to deploy remote server, if possible
/mcp
endpoint.close https://github.com/apify/ai-team/issues/64