-
Notifications
You must be signed in to change notification settings - Fork 117
docs: add APIFY_USER_IS_PAYING
env var documentation
#1706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
APIFY_USER_IS_PAYING
env var docsAPIFY_USER_IS_PAYING
env var documentation
Preview for this PR was built for commit |
Preview for this PR was built for commit |
Preview for this PR was built for commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good!
I'm wondering, should we explain who is a paying user here? Or is it really as simple as "is not on the free plan"? :)
@@ -62,6 +62,7 @@ Here's a table of key system environment variables: | |||
| `ACTOR_TIMEOUT_AT` | Date when the Actor will time out. | | |||
| `APIFY_TOKEN` | API token of the user who started the Actor. | | |||
| `APIFY_USER_ID` | ID of the user who started the Actor. May differ from the Actor owner. | | |||
| `APIFY_USER_IS_PAYING` | If set to `1`, the user calling the Actor is paying user. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `APIFY_USER_IS_PAYING` | If set to `1`, the user calling the Actor is paying user. | | |
| `APIFY_USER_IS_PAYING` | If set to `1`, the user calling the Actor is a paying user. | |
It is that simple. (actually not right now in this moment, now there are some issues with HT customers, which is also kind of an internal thing, but that will be gone in a week anyway, so I think we don't need to explain) |
Preview for this PR was built for commit |
@@ -62,6 +62,7 @@ Here's a table of key system environment variables: | |||
| `ACTOR_TIMEOUT_AT` | Date when the Actor will time out. | | |||
| `APIFY_TOKEN` | API token of the user who started the Actor. | | |||
| `APIFY_USER_ID` | ID of the user who started the Actor. May differ from the Actor owner. | | |||
| `APIFY_USER_IS_PAYING` | If set to `1`, the user calling the Actor is a paying user. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not set by anyone manually, rather retrieved?
| `APIFY_USER_IS_PAYING` | If set to `1`, the user calling the Actor is a paying user. | | |
| `APIFY_USER_IS_PAYING` | Contains `1` if the user who started the Actor is a paying user. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is set by the platform.
But to me, "Contains" is a little ambiguous. It sounds like it can be an array or a string having "1" in it. So I would be unsure what to expect from this variable ["2", "21", "1"] or "He11o".
What about If it is...., it means that...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense to me, feel free to adjust like so, and I'll go over other env vars later today and make sure that language is similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Preview for this PR was built for commit |
Adds `APIFY_USER_IS_PAYING` environmental variable as `userIsPaying` to the `ApifyEnv` interface. PR adding it to the documentation is here: apify/apify-docs#1706
Adds `APIFY_USER_IS_PAYING` environmental variable to the `ApifyEnvVars` PR with updated documentation is here: apify/apify-docs#1706
Add documentation for
APIFY_USER_IS_PAYING
environmental variable.userIsPaying
to the env var interface apify-sdk-js#415APIFY_USER_IS_PAYING
env var to theApifyEnvVars
apify-shared-python#40APIFY_USER_IS_PAYING
env var annotation to the configuration apify-sdk-python#507