Skip to content

feat: move restartOnError from Actor to Run options #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+9 −2
Open

feat: move restartOnError from Actor to Run options #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38ee296
feat: move restartOnError from Actor to Run options
DaveHanns Oct 2, 2025
3777136
feat: deprecate restartOnError instead of removing it
DaveHanns Oct 3, 2025
e38d0d8
chore: better wording of deprecation message
DaveHanns Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/resource_clients/actor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ export interface Actor {
name: string;
username: string;
description?: string;
/** @deprecated Use defaultRunOptions.restartOnError instead */
restartOnError?: boolean;
isPublic: boolean;
isAnonymouslyRunnable?: boolean;
Expand Down Expand Up @@ -305,6 +306,7 @@ export interface ActorDefaultRunOptions {
build: string;
timeoutSecs: number;
memoryMbytes: number;
restartOnError?: boolean;
}

export interface ActorExampleRunInput {
Expand All @@ -330,12 +332,14 @@ export type ActorUpdateOptions = Partial<
| 'seoTitle'
| 'seoDescription'
| 'title'
| 'restartOnError'
| 'versions'
| 'categories'
| 'defaultRunOptions'
| 'actorStandby'
>
> & {
/** @deprecated Use defaultRunOptions.restartOnError instead */
restartOnError?: boolean;
}
>;

export interface ActorStandby {
Expand Down Expand Up @@ -486,6 +490,7 @@ export interface ActorRunOptions {
memoryMbytes: number;
diskMbytes: number;
maxTotalChargeUsd?: number;
restartOnError?: boolean;
}

export interface ActorBuildOptions {
Expand Down
1 change: 1 addition & 0 deletions src/resource_clients/actor_collection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ export interface ActorCollectionCreateOptions {
isDeprecated?: boolean;
isPublic?: boolean;
name?: string;
/** @deprecated Use defaultRunOptions.restartOnError instead */
restartOnError?: boolean;
seoTitle?: string;
seoDescription?: string;
Expand Down
1 change: 1 addition & 0 deletions src/resource_clients/schedule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ export interface ScheduledActorRunOptions {
build: string;
timeoutSecs: number;
memoryMbytes: number;
restartOnError?: boolean;
}

export interface ScheduleActionRunActorTask extends BaseScheduleAction<ScheduleActions.RunActorTask> {
Expand Down
Loading