Add tests for the CLI command #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bbenligiray
reviewed
Aug 19, 2025
src/cli.test.ts
Outdated
| const formattedArgs = args | ||
| .map(([c, a]) => { | ||
| // if args is array then quote each elem and separate them with space | ||
| if (Array.isArray(a)) return `${c} ${a.map((element) => quote(element)).join(' ')}`; |
Member
There was a problem hiding this comment.
The CommandArg type definition above says a's type can be string | number | boolean. I don't see why we're handling the case where a is an array here.
Contributor
Author
There was a problem hiding this comment.
Right it is unnecessary. It was checking string[] at first which is not necessary after iterating the code.
bbenligiray
reviewed
Aug 19, 2025
src/cli.test.ts
Outdated
| ['--chain-id', '5000'], | ||
| ['--dapi-name', 'UNSUPPORTED/USD'] | ||
| ); | ||
| }).toThrow(/⚠️ Attempted to read the feed and failed/); |
Member
There was a problem hiding this comment.
This probably shouldn't be a partial match (/ are extra)
bbenligiray
reviewed
Aug 19, 2025
src/cli.test.ts
Outdated
|
|
||
| describe('cli tests', () => { | ||
| const execCommand = (command: string, ...args: CommandArg[]) => { | ||
| const quote = (val: string) => `"${val}"`; |
Member
There was a problem hiding this comment.
I think you should also get rid of quote() considering that we're not recommending the user to enclose argument values in quotation marks anywhere. That was an airnode-admin thing where seed phrases needed to be enclosed because they have spaces in them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #363
There are some limitations testing the CLI command
The child process spawned by execSync:
to test with mocks the code should be refactored so that core logic is a function and can be exported.