Skip to content

Conversation

@hiletmis
Copy link
Contributor

@hiletmis hiletmis commented Jun 4, 2025

Copy link
Contributor

@bdrhn9 bdrhn9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@@ -1271,38 +1271,7 @@
"type": "function"
}
],
"transactionHash": "0xca6d679bca21c5bbb94b36b508d04429c89b4e59df95634a0dd61793c07391a9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wondered why these fields are removed rather than changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contracts were already deployed on network test (last week). On second deploy attempt (this PR) it says the contract is already deployed and recreates json files except this time it does not know transaction details.

@hiletmis hiletmis marked this pull request as ready for review June 5, 2025 06:50
@hiletmis hiletmis requested a review from bbenligiray as a code owner June 5, 2025 06:50
@hiletmis hiletmis merged commit d878b39 into main Jun 5, 2025
4 checks passed
@hiletmis hiletmis deleted the migrate-core-testnet branch June 5, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants