-
-
Notifications
You must be signed in to change notification settings - Fork 934
feat(symfony): Add an option to #[ApiResource]
to keep the class as service
#7403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -189,10 +189,11 @@ public function load(array $configs, ContainerBuilder $container): void | |
->addTag('api_platform.uri_variables.transformer'); | ||
$container->registerForAutoconfiguration(ParameterProviderInterface::class) | ||
->addTag('api_platform.parameter_provider'); | ||
$container->registerAttributeForAutoconfiguration(ApiResource::class, static function (ChildDefinition $definition): void { | ||
$definition->setAbstract(true) | ||
->addTag('api_platform.resource') | ||
->addTag('container.excluded', ['source' => 'by #[ApiResource] attribute']); | ||
$container->registerAttributeForAutoconfiguration(ApiResource::class, static function (ChildDefinition $definition, ApiResource $attribute): void { | ||
$definition->addTag('api_platform.resource'); | ||
if ($attribute->registerAsController) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Given the name did you want to do the opposite ?
|
||
$definition->setAbstract(true)->addTag('container.excluded', ['source' => 'by #[ApiResource] attribute']); | ||
}; | ||
}); | ||
$container->registerAttributeForAutoconfiguration( | ||
AsResourceMutator::class, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure for the name. Any better idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it could work with any service and not only controller, maybe
registerAsService
orexposeAsService
(?)Or the inverted
excludeFromContainer
.but the issue is that such name is really related to the symfony configuration, and it might be weird on laravel side to have a useless option.
What's the benefit of
$definition->setAbstract(true)->addTag('container.excluded', ['source' => 'by #[ApiResource] attribute']);
for dto ?Also, couldn't it be automatically detected/added only if the class is not already registered/autowired (as a service/controller) (?)
But given the "wrong" use I did with ApiResource to document some controller route, I wonder if the right solution wouldn't to expose another dedicated attribute for my usage (which could be used on Controller class or directly on a route) like
#[ApiRoute]
(?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature might already exists
#7402 (comment)